extension: bump the submodule past the lint fixes - #21
Merged
Conversation
The extension leg of the CI has been red since it was added, and it is not the workflow's fault: this repo pinned extension at 8f75f07d8b, which predates urnetwork/extension#36. `npm run lint` fails there with 12 errors -- 9 no-explicit-any, an unused parameter, and two react-hooks/refs violations, one of which was a real correctness bug (refs assigned during render, feeding a ConnectionManager built once with [] deps that invokes the auth thunk from timers). #36 fixed all twelve and merged upstream, but a submodule pin does not follow a merge in the component repo. So CI kept building the pre-fix tree and kept reporting the same twelve errors. Worth noting as a pattern rather than a one-off: this is the second time a pin lag has produced a red leg that looked like a CI defect. The Arch package leg was the first -- it warned and skipped for two runs because packaging/make-arch.sh did not exist at the pinned linux commit. Now that every component repo builds and tests itself on push, the build repo's pins are the thing most likely to go stale, and a stale pin presents as a failure in whatever the pin feeds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MAXFxG1EK4jTxQ1iW73BUr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension leg of CI has been red since it was added. It is not the
workflow's fault — this repo pins
extensionat8f75f07d8b, which predatesurnetwork/extension#36.
npm run lintfails at that commit with 12 errors.#36 fixed all twelve and merged, but a submodule pin does not follow a merge in
the component repo, so CI kept building the pre-fix tree and kept reporting the
same twelve errors.
What this picks up
4e1c494c7is the one that matters beyond lint: refs were being assigned duringrender, feeding a
ConnectionManagerbuilt once with[]deps that invokes theauth thunk from timers — so a discarded render could publish a callback into a
live long-lived object.
A pattern, not a one-off
This is the second time a stale pin has produced a red leg that looked like a
CI defect. The Arch package leg was the first: it warned and skipped for two runs
because
packaging/make-arch.shdid not exist at the pinnedlinuxcommit.Now that every component repo builds and tests itself on push, this repo's pins
are the thing most likely to go stale — and a stale pin always presents as a
failure in whatever that pin feeds, not as "the pin is old". Worth considering a
periodic pin-bump job so CI keeps testing what the components actually ship.