Skip to content

extension: bump the submodule past the lint fixes - #21

Merged
Ryanmello07 merged 1 commit into
mainfrom
fix/extension-pin
Aug 22, 2026
Merged

extension: bump the submodule past the lint fixes#21
Ryanmello07 merged 1 commit into
mainfrom
fix/extension-pin

Conversation

@Ryanmello07

Copy link
Copy Markdown
Contributor

The extension leg of CI has been red since it was added. It is not the
workflow's fault
— this repo pins extension at 8f75f07d8b, which predates
urnetwork/extension#36.
npm run lint fails at that commit with 12 errors.

#36 fixed all twelve and merged, but a submodule pin does not follow a merge in
the component repo
, so CI kept building the pre-fix tree and kept reporting the
same twelve errors.

What this picks up

9f4d6fdf6  ci: build and test the extension on push
0f912dec0  ci: report lint without gating build and test
c793894d5  ci: add timeout and concurrency; correct the lint comment
4e1c494c7  fix(connect): stop writing the SDK callback refs during render
fbc4ec63f  fix(types): replace the nine `any` casts and drop an unused list
660e05e39  Merge pull request #36 from urnetwork/fix/lint-errors

4e1c494c7 is the one that matters beyond lint: refs were being assigned during
render, feeding a ConnectionManager built once with [] deps that invokes the
auth thunk from timers — so a discarded render could publish a callback into a
live long-lived object.

A pattern, not a one-off

This is the second time a stale pin has produced a red leg that looked like a
CI defect. The Arch package leg was the first: it warned and skipped for two runs
because packaging/make-arch.sh did not exist at the pinned linux commit.

Now that every component repo builds and tests itself on push, this repo's pins
are the thing most likely to go stale
— and a stale pin always presents as a
failure in whatever that pin feeds, not as "the pin is old". Worth considering a
periodic pin-bump job so CI keeps testing what the components actually ship.

The extension leg of the CI has been red since it was added, and it is
not the workflow's fault: this repo pinned extension at 8f75f07d8b,
which predates urnetwork/extension#36. `npm run lint` fails there with
12 errors -- 9 no-explicit-any, an unused parameter, and two
react-hooks/refs violations, one of which was a real correctness bug
(refs assigned during render, feeding a ConnectionManager built once
with [] deps that invokes the auth thunk from timers).

#36 fixed all twelve and merged upstream, but a submodule pin does not
follow a merge in the component repo. So CI kept building the pre-fix
tree and kept reporting the same twelve errors.

Worth noting as a pattern rather than a one-off: this is the second time
a pin lag has produced a red leg that looked like a CI defect. The Arch
package leg was the first -- it warned and skipped for two runs because
packaging/make-arch.sh did not exist at the pinned linux commit. Now
that every component repo builds and tests itself on push, the build
repo's pins are the thing most likely to go stale, and a stale pin
presents as a failure in whatever the pin feeds.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MAXFxG1EK4jTxQ1iW73BUr
@Ryanmello07
Ryanmello07 marked this pull request as ready for review August 22, 2026 08:27
@Ryanmello07
Ryanmello07 merged commit da10626 into main Aug 22, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant