fix(core): include GraphQL error messages in CombinedError.message when a networkError is also present - #3911
Open
usamabhatti1998 wants to merge 1 commit into
Conversation
…en a networkError is also present
🦋 Changeset detectedLatest commit: a7b1ce7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CombinedError's message generator (generateErrorMessage) returns early as soon as anetworkErroris present, so if aCombinedErrorever carries both anetworkErrorandgraphQLErrors(this happens for real after an SSR round-trip throughssrExchange'sserializeResult/deserializeResult, since both fields are serialized independently), every GraphQL error message is silently dropped from.message/\${error}`. The structured.graphQLErrors` array was always correct — only the human-readable message lost data.Set of changes
packages/core/src/utils/error.ts: stop short-circuiting onnetworkErringenerateErrorMessage; append its message and fall through to the existing GraphQL-error loop instead.packages/core/src/utils/error.test.ts: add a test covering both error types being present simultaneously.patchon@urql/core).Not a breaking change — behavior for network-only and GraphQL-only errors (the two cases every existing test covers) is byte-for-byte identical; only the previously-untested "both present" case changes, from silently dropping data to including it.