feat: support multiple MirageOS block devices - #908
Open
pocopepe wants to merge 1 commit into
Open
Conversation
Ref: urunc-dev#315 Signed-off-by: viju <avijusanjai@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Block devices from #315, comma separated as discussed.
solo5BlkDev,blockandblkMntPointnow take ordered comma separated lists, mapped positionally. Single device setups are unaffected. Added guards for empty list entries and for mixing a/mounted block with others, both error out instead of silently mismapping.3.1 of 3 from #315.
Related issues
How was this tested?
Built a MirageOS unikernel declaring two block devices in its Solo5 manifest,
storageanddata, and ran it through urunc/containerd end to end.Both devices declared and attached:
Mismatched annotation counts, caught before the VM ever boots:
Pushed images:
LLM usage
Claude Sonnet 5
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).