fix(viewer): keep scroll anchor across wrap toggles and stop scroll stutter on upward scroll - #22
Merged
Merged
Conversation
ScrollView.onSizeChanged re-scrolls to keep a focused descendant visible. Code blocks are selectable TextViews and therefore focusable, and the chrome's expand/collapse animation resizes the viewport every frame — so that automatic scroll landed mid-drag, and the deltas it emitted flipped the chrome's own show/hide threshold straight back. Also stop routing the live scroll position through composition. It recomposed the whole screen, and the AndroidView update block, on every scroll frame, where an animated text colour then rebuilt the segment view tree and cancelled the gesture in flight.
A table segment has no TextView, so resolving its anchor fell through to 0 and sent the viewer to the top of the document. Distinguish "unresolvable" from "position 0" and hold position instead. Also fix the double-counted container padding in the split path, narrow the focused-descendant scroll suppression to the two callers that actually misbehave so selection handles still auto-scroll, and drop the no-op DirectionalHorizontalScrollView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.