test(playground): cover timers and async code in the quickjs sandbox - #66
Merged
arpit-bruno merged 1 commit intoSep 2, 2026
Merged
Conversation
arpit-bruno
approved these changes
Sep 2, 2026
arpit-bruno
left a comment
arpit-bruno
left a comment
Collaborator
There was a problem hiding this comment.
One note for reference (non-blocker for now): few tests only passes because the vm is never disposed as vm.dispose() is still commented out. Thats what lets the timer fire and set a var after the run has already finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA : Bru-3838
Description
Adds test cases for timers and async code running inside the quickjs sandbox.