ci: run the packages/* pytest suites - #492
Open
igor17400 wants to merge 1 commit into
Open
Conversation
igor17400
requested review from
HarshaNalluru,
ashvathsureshkumar and
r4ghu
as code owners
July 26, 2026 00:05
Codex reviewNo issues found. |
Contributor
|
@igor17400 please sign the CLA #492 (comment) |
Author
|
@HarshaNalluru Done! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for Python package test suites living under packages/*, addressing a gap where these tests were previously not executed in any workflow. This fits the repo’s multi-package structure by ensuring non-SDK Python packages get continuous validation in the main CI pipeline.
Changes:
- Introduces a new
python-package-testGitHub Actions matrix job to runpytestfor 13 selected packages underpackages/*. - Standardizes package test execution via
uv sync --all-extrasfollowed byuv run ... pytest tests -v. - Pins the job to Python 3.12 and documents exclusions/constraints inline (notably excluding
packages/moss-cli).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
The pytest suites under
packages/*ran nowhere:ci.ymlcovered onlysdks/python/sdkand the langchain cookbook, and thepublish-*.ymlworkflows only smoke-testimport <package>.Adds a
python-package-testmatrix job covering the 13 packages whose suites currently pass — ~120 tests. Verified locally with the exact commands the job runs:Two constraints, both documented in comments in the workflow:
moss_connector_<x>.ingest.MossClient, but each package's__init__.pydoesfrom .ingest import ingest, shadowing the submodule with the function.unittest.mockresolves that target on 3.12+ and raisesAttributeErroron 3.10/3.11. Test-only the packages themselves are fine on 3.10.packages/moss-cliis excluded.moss completions bash|zshexits 1 even when its fallback import succeeds (commands/completions.py), sotests/test_completions.pyfails:2 failed, 28 passed. Worth a follow-up PR that fixes the command and adds moss-cli to the matrix.Type of Change
CI / tooling — no runtime code changes.