Feat: Listar e buscar tipos de relevo Api.v2 - #506
Open
JosueModesto wants to merge 6 commits into
Open
JosueModesto wants to merge 6 commits into
JosueModesto wants to merge 6 commits into
Conversation
edvaldoszy
reviewed
Sep 10, 2026
| buscarRelevoPorIdUseCase: BuscarRelevoPorIdUseCase | ||
| } | ||
|
|
||
| export class BuscarRelevoController implements RequestHandler { |
Collaborator
There was a problem hiding this comment.
Os tipos BuscarRelevo* repetem o infinitivo já presente em vegetação. Em módulos v2 novos o verbo deve ficar na 3ª pessoa do presente: EncontraRelevoController, EncontraRelevoPorIdUseCase e o teste encontra-relevo.test.ts.
edvaldoszy
reviewed
Sep 10, 2026
| }) | ||
| }) | ||
|
|
||
| describe('GET /api/v2/relevos/:relevoId', () => { |
Collaborator
There was a problem hiding this comment.
Este arquivo cobre listagem e busca por id. A convenção do repo é um arquivo de teste por ação (kebab-case do mesmo verbo + recurso), então a busca por id deveria ir para encontra-relevo.test.ts.
edvaldoszy
reviewed
Sep 10, 2026
| @@ -55,7 +56,8 @@ export function createApp({ | |||
| }: Parameters) { | |||
| const routes: Route[] = [ | |||
| ...createPaisRoutes(knex), | |||
Collaborator
There was a problem hiding this comment.
O PR está em conflito com development. No rebase, registre createRelevoRoutes sem remover createVegetacaoRoutes, que já existe na base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #491
O que foi feito
Foi implementado o módulo de leitura de tipos de relevo na API v2, preservando o comportamento legado da rota antiga.
Alterações principais
Cobertura de testes