feat(flow-client): port the engine assembly to TypeScript - #24952
feat(flow-client): port the engine assembly to TypeScript#24952totally-not-ai[bot] wants to merge 8 commits into
Conversation
Review — 1:1 Java→TS port fidelityReviewed the engine-assembly files against Production code — faithful ✅
Intentional/safe divergences (worth confirming, none blocking):
Minor findings (please confirm intent)
Tests
Recommendation: production wiring is good to go pending confirmation of the two MINOR null/warning deviations. On tests, port (or explicitly defer with a note) the |
Ports the top layer that wires the client together: DefaultRegistry (the DI hub that instantiates every service), ApplicationConnection (the engine entry via ApplicationConnection.create), Bootstrapper, and the published client API (publishClient, clientApi). Completes the TypeScript port of the client engine -- all 80 internal modules are now present and unit-tested. Still additive: nothing is wired into the running client (GWT remains live); the cutover is a separate step. Depends on PR1-6. Exercised by mocha (23 tests).
fbfbe84 to
760dd0a
Compare
a5a34a8 to
6244dc5
Compare
Summary
Ports the top layer that wires the client together:
DefaultRegistry(the DI hub instantiating every service),ApplicationConnection(the engine entry viaApplicationConnection.create),Bootstrapper, and the published client API (publishClient,clientApi). Completes the TypeScript port — all 80 internal engine modules are now present and unit-tested.Additive only — nothing is wired into the running client (GWT remains the live engine); exercised by mocha (23 tests).
tsc+eslintclean.Stacked on #24951 (base
flow-client-ts-network) — merge after it. This PR's diff is only its own new files (additive, no edits to existing code), so it can be reviewed independently of the merge order.