chore(flow-client): remove the GWT client engine and build wiring - #24954
chore(flow-client): remove the GWT client engine and build wiring#24954totally-not-ai[bot] wants to merge 2 commits into
Conversation
Review — GWT client engine + build wiring removalThe removal is complete and internally consistent:
One follow-up that this removal breaks (please address or confirm handled elsewhere)
if (jsUrl.endsWith(".cache.js") && jsUrl.contains("static/client/client-")) {
foundClientEngine = true;
}With the engine gone, Minor cleanup leftovers (non-blocking)
Otherwise LGTM — thorough, correct removal with no dangling imports or build references. |
a5a8c19 to
4f5d7f2
Compare
With the TypeScript engine now the live client (previous commit), the GWT client is dead. Remove it: the com.vaadin.client.* sources and their JUnit + GWTTestCase tests, the ClientEngine*.gwt.xml modules, ClientEngineLinker and its single-script template, and the GWT dependencies / gwt-maven-plugin / GWT test wiring from pom.xml and package.json. flow-client is now a TypeScript + resources module with no Java sources. Nothing outside flow-client referenced com.vaadin.client.
…t exclusions (review)
9d706b9 to
f9d6cf7
Compare
|



Summary
With the TypeScript engine now live (previous PR), the GWT client is dead. Removes it:
com.vaadin.client.*sources + their JUnit/GWTTestCase tests, theClientEngine*.gwt.xmlmodules,ClientEngineLinker+ its single-script template, and the GWT deps /gwt-maven-plugin/ GWT test wiring frompom.xmlandpackage.json.flow-client is now a TypeScript + resources module with no Java sources. Nothing outside flow-client referenced
com.vaadin.client. Large but mechanical (deletions).Stacked on #24953 (base
flow-client-ts-cutover) — merge after it. Non-draft; please review before merging.