chore(flow-client): rename eslint config to .mjs and quiet the Lit dev-mode banner - #24956
Closed
totally-not-ai[bot] wants to merge 3 commits into
Closed
chore(flow-client): rename eslint config to .mjs and quiet the Lit dev-mode banner#24956totally-not-ai[bot] wants to merge 3 commits into
totally-not-ai[bot] wants to merge 3 commits into
Conversation
Contributor
Author
Review — eslint config rename + quiet Lit dev-mode bannerBoth changes are sound.
LGTM. |
totally-not-ai
Bot
force-pushed
the
flow-server-remove-client-engine
branch
from
July 8, 2026 17:01
189f26e to
eaf9955
Compare
totally-not-ai
Bot
force-pushed
the
flow-client-ts-polish
branch
from
July 8, 2026 17:01
0d97f26 to
86b564e
Compare
…v-mode banner - Rename eslint.config.js to eslint.config.mjs so Node treats the ESM config as a module (removes the MODULE_TYPELESS_PACKAGE_JSON warning) without adding "type": "module" (scripts/client.js stays CommonJS). - web-test-runner: pre-mark Lit's "dev-mode" warning as issued before any module loads, keeping the banner out of test output; scope test discovery to *Tests.ts.
totally-not-ai
Bot
force-pushed
the
flow-client-ts-polish
branch
from
July 8, 2026 18:51
86b564e to
a62c75a
Compare
totally-not-ai
Bot
force-pushed
the
flow-server-remove-client-engine
branch
from
July 8, 2026 18:51
eaf9955 to
057c9fb
Compare
Contributor
Author
|
Superseded by #24979 — head branch renamed to |
mcollovati
pushed a commit
that referenced
this pull request
Jul 20, 2026
…v-mode banner (#24979) Small polish: - Rename `eslint.config.js` → `eslint.config.mjs` so Node treats the ESM config as a module (drops the `MODULE_TYPELESS_PACKAGE_JSON` warning) without adding `"type": "module"` (`scripts/client.js` stays CommonJS). - web-test-runner: pre-mark Lit's `dev-mode` warning as issued before any module loads, keeping the banner out of test output; scope discovery to `*Tests.ts`. **Stacked on #24955** (base `flow-server-remove-client-engine`) — merge after it. Non-draft; please review before merging. --- _Re-created from #24956 after renaming the head branch `flow-client-ts-polish` → `feature/client-ts` (the canonical branch for the full client TS migration). GitHub orphaned the original PR on rename._ Co-authored-by: Artur Signell <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small polish:
eslint.config.js→eslint.config.mjsso Node treats the ESM config as a module (drops theMODULE_TYPELESS_PACKAGE_JSONwarning) without adding"type": "module"(scripts/client.jsstays CommonJS).dev-modewarning as issued before any module loads, keeping the banner out of test output; scope discovery to*Tests.ts.Stacked on #24955 (base
flow-server-remove-client-engine) — merge after it. Non-draft; please review before merging.