refactor: use the elemental DOM API directly in the client engine - #25146
Open
Artur- wants to merge 3 commits into
Open
refactor: use the elemental DOM API directly in the client engine#25146Artur- wants to merge 3 commits into
Artur- wants to merge 3 commits into
Conversation
DomApi.wrap only returned the node itself after the Polymer DOM API was removed, and DomNode and DomElement describe the same native DOM operations as elemental Node and Element. Call sites now use the elemental types directly, which also lets StateTree.getStateNodeForDomNode accept a Node. DomApiAbstractionUsageTest verified that every DOM call went through DomApi.wrap so that Polymer could rewrite the operation. There is nothing left to rewrite, so the test is removed together with the abstraction.
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Artur-
marked this pull request as ready for review
August 11, 2026 13:58
|
Contributor
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DomApi.wrap only returned the node itself after the Polymer DOM API was removed, and DomNode and DomElement describe the same native DOM operations as elemental Node and Element. Call sites now use the elemental types directly, which also lets StateTree.getStateNodeForDomNode accept a Node.
DomApiAbstractionUsageTest verified that every DOM call went through DomApi.wrap so that Polymer could rewrite the operation. There is nothing left to rewrite, so the test is removed together with the abstraction.