fix: log unsafe URL fallback at warn level - #25181
Closed
vedansh0410 wants to merge 1 commit into
Closed
Conversation
|
|
Author
|
Hi, the TeamCity validation checks appear to be failing with user: vedansh0410 is not a flow team member. Could you please check whether this is related to the CI permissions/configuration for external contributors? The change and tests pass locally. |
mshabarov
self-requested a review
August 12, 2026 06:52
Member
|
We're considering a slightly more elaborate approach instead: #25185 |
Contributor
|
Closing this PR in a favor of the mentioned one. Thanks for the contribution nevertheless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No new dependencies are required.
When
UrlUtil.isSafeUrl(String)is called without aVaadinServiceavailable on the current thread, the URL safety check falls back to the default safe URL schemes. This fallback was previously logged at DEBUG level.This change raises the log level from DEBUG to WARN so that application developers have a better chance of noticing when the configured URL safety schemes cannot be applied.
A test has been added to verify that the fallback behavior still uses the default safe URL schemes when no
VaadinServiceis available.Fixes #25086
Type of change
Checklist
Additional for
Featuretype of change