fix(board): restore breadcrumb regressions from #267 - #273
Merged
Merged
Conversation
- Re-add the `group` class to the sheet panel body header so NoteIconControl's hover-revealed "Add icon" button works again for un-iconed sheets (it relies on group-hover; the class was dropped when the title was restored). - Add data-coachmark="title" to the breadcrumb's board-name element so the empty board "name your canvas" onboarding callout anchors again (the old FolderBreadcrumb carried it; the new one didn't). - Scope the root edit target by boardId so switching boards mid-rename abandons the in-flight edit instead of committing one board's draft onto another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #267 (unified board breadcrumb). A
/code-review highpass incidentally re-scanned the merged #267 code and surfaced these regressions, all verified againstmain.Fixes
groupclass from the panel body header;NoteIconControl's "Add icon" button isopacity-0+group-hover:opacity-100, so with nogroupancestor it stayed permanently invisible. Re-addedgroup.data-coachmark="title"existed nowhere after the refactor — the oldFolderBreadcrumbcarried it, the newBoardBreadcrumbdidn't, andempty-board-coachmarks.tsxqueries for it (null-> callout dropped). Added it to the breadcrumb's board-name element (root only).boardIdso switching boards changes the target and abandons the in-flight edit.Not included
The reviewer also flagged that folder-depth now derives from the on-device replica (
useLocalBoardContents) rather than the backend note-path, so a synced board with a lagging replica could transiently under-count depth and allow a sub-board past the limit. Left as-is: it's the intended offline-first source of truth (the replica is complete post-sync), and reintroducing a backend note-path call just for the depth gate contradicts that direction. Noted here for visibility.Test plan
npm run check-all: cleannpm run test:run: 1354 passed