Skip to content

chore(traces): Add source layout marker to trace event metadata - #26291

Open
bruceg wants to merge 1 commit into
masterfrom
bruceg/trace-layout-metadata-marker
Open

chore(traces): Add source layout marker to trace event metadata#26291
bruceg wants to merge 1 commit into
masterfrom
bruceg/trace-layout-metadata-marker

Conversation

@bruceg

@bruceg bruceg commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

Have datadog_agent and opentelemetry write an internal, unstable %vector.trace_layout marker on emitted traces so a later consumer can tell the layouts apart after source_type is rewritten (for example across a vector sink/source hop).

References

Vector configuration

N/A

How did you test this PR?

Included unit tests

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.

@bruceg
bruceg requested a review from a team as a code owner September 3, 2026 00:09
@bruceg bruceg added type: tech debt A code change that does not add user value. domain: data model Anything related to Vector's internal data model domain: traces Anything related to Vectors' trace events domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Sep 3, 2026
@github-actions github-actions Bot added the domain: sources Anything related to the Vector's sources label Sep 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c59b99a63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/format/otlp.rs Outdated
Comment thread lib/vector-core/src/event/metadata.rs
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T23:13:00.079789Z 54ee459 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bruceg
bruceg force-pushed the bruceg/trace-layout-metadata-marker branch from 8c59b99 to 83d5c55 Compare September 3, 2026 01:12
@github-actions github-actions Bot added the domain: transforms Anything related to Vector's transform components label Sep 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83d5c5538b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/vector-core/src/vrl.rs Outdated
@bruceg
bruceg force-pushed the bruceg/trace-layout-metadata-marker branch from 83d5c55 to 8c2580f Compare September 3, 2026 19:14
@bruceg
bruceg requested a review from tessneau September 3, 2026 22:20
Have datadog_agent and opentelemetry write an internal, unstable
`%vector.trace_layout` marker on emitted traces so a later consumer can
tell the layouts apart after `source_type` is rewritten (for example
across a vector sink/source hop).
@bruceg
bruceg force-pushed the bruceg/trace-layout-metadata-marker branch from 8c2580f to 54ee459 Compare September 8, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: data model Anything related to Vector's internal data model domain: sources Anything related to the Vector's sources domain: traces Anything related to Vectors' trace events domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant