Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/fallible_event_proto_decode.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Decoding Vector's native protobuf format (`decoding.codec = "native"`) and disk-buffer records no longer panics when an event variant is missing or unrecognized, when a float field is `NaN`, or when an AgentDDSketch has mismatched bin lists. Those payloads are rejected, dropped, and reported through existing decode/buffer error telemetry. A `NaN` float in event data or metadata rejects the entire record rather than rewriting the value.

authors: bruceg
2 changes: 1 addition & 1 deletion lib/codecs/src/decoding/format/native.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ impl Deserializer for NativeDeserializer {
if bytes.is_empty() {
Ok(smallvec![])
} else {
let event_array = EventArray::from(proto::EventArray::decode(bytes)?);
let event_array = EventArray::try_from(proto::EventArray::decode(bytes)?)?;
Ok(event_array.into_events().collect())
}
}
Expand Down
Loading
Loading