feat: update library as per draft-ietf-rats-corim-11 spec - #21
Open
shefali-kamal wants to merge 2 commits into
Open
feat: update library as per draft-ietf-rats-corim-11 spec#21shefali-kamal wants to merge 2 commits into
shefali-kamal wants to merge 2 commits into
Conversation
…triple parsing, as they are not supported by the Arm CCA, only supported scheme as of now by Cover - Update README and lib.rs to remove obsolete CE Series triple parsing references - update dependencies and remove unsupported CE parsing - Fix Clippy redundant-reference warning with Clippy 0.1.97 - Update anyhow to 1.0.104 to address cargo-deny advisory warning Signed-off-by: Patel, Ajay Kumar <Ajaykumar.Patel@fujitsu.com>
setrofim
reviewed
Sep 4, 2026
setrofim
left a comment
setrofim
left a comment
Contributor
There was a problem hiding this comment.
Also, please update the commit message to be compliant with conventions commits:
Update(library):are not valid type/scope; should be justfeat:(the scope is optional and can be omitted if the change is not local to a specific part).- Commit title should not end with a period.
- Commits that break compatibility should have a
!following the type/scope (before the:), and should have aBREAKING CHANGE:footer explaining the nature of the change.
| } | ||
| let result = verifier.verify(&args.scheme, evidence.as_slice(), nonce.as_deref())?; | ||
|
|
||
| debug!("ACS: {}", serde_json::to_string(&result.acs)?); |
There was a problem hiding this comment.
My bad, deleted while removing other debugging statements. Will add it back.
| based on an identifier inside the evidence. This is scheme-specific. For CCA, the instance ID | ||
| is used. Evidence claims are then extracted as ECT (environment-claims tuple) records. | ||
| - The evidence ECTs are then matched to the relations in the corim store. This results in the | ||
| ACS (appraisal claims set) -- a vector of ECT records containing evidence claims and matched |
Contributor
There was a problem hiding this comment.
This is correct. -- in ASCII indicates an em-dash (rather than a hypen), which is what is intended here.
shefali-kamal
changed the title
shefali-kamal
changed the title
shefali-kamal
changed the title
- Refactor ECT structures by introducing CommonEct and renaming Ect to ElementEct. Ect now refers to enum representing all ect(s) - Add key-ect support and populate key relations from key triple records - Add support for inputting verfier-key and use it as authority for for key addition ect - For unsigned corims, input verifier-key is used as authority - Refactor evidence/reference-value measurement map conversion using From trait on ElementMap - Update CM-Type handling according to CoRIM spec revision 11. Supported only 3 types of cm-type now - Add profile compatibility checks for input evidence formats - Validate CoRIMs and reject expired or unsupported profiles CoRIMs - Added Unit tests for added functionality - Update test data, with CCA required fields, and tests to ensure the complete test suite passes - Apply Rust formatting and Clippy fixes and bump dependencies to latest versions Signed-off-by: Patel, Ajay Kumar <Ajaykumar.Patel@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduced below changes/updates:
Remove CE and CES:
Update library as per draft-ietf-rats-corim-11:
Fromtrait onElementMap