[Bench] Fixes for pure Fizz bench - #96771
Merged
Merged
Conversation
Contributor
Tests PassedCommit: cf8a1ce |
Contributor
Stats skippedCommit: cf8a1ce |
gaearon
marked this pull request as ready for review
August 5, 2026 22:46
ztanner
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harness fixes, all surfaced while benching a Fizz-only React PR (react/react#37022):
prof-order.txt) so analyses can check order drift directly.FP_FILEShashed only the vendored Flight server files, which a Fizz-only React change leaves byte-identical — both arms of a valid A/B reported the same fingerprint. Added the vendored Fizz bundle and the shared react-server runtime (hooks/cache) in both suites. The VM boot loop also warns loudly when arms fingerprint identically, instead of leaving it for the analysis footer.--preparewrites a terminal status phase. It previously exited leavingphase: "measuring", sobench-statusprescribed collecting measurement data that never existed.bench-statusnow reports prepare-only runs as complete rather than "DEAD — relaunch".Verification
run-pr37022-e2e-prof2): arms fingerprint distinctly (18ea275evsf9805be5), profile order alternates per VM, untouched hot frames diff to ~zero in the cross-VM profile aggregate.bench-status.mjsagainst a real--preparerun dir reportscomplete (--prepare: caches only).--dry-runsmoke of the modified launcher;node --checkon all three scripts.