Skip to content

chore: open the 0.1.1266-rc prerelease line - #4649

Merged
kwakayama merged 1 commit into
mainfrom
chore/open-0.1.1266-rc
Sep 28, 2026
Merged

kwakayama merged 1 commit into
mainfrom
chore/open-0.1.1266-rc

Conversation

@kwakayama

@kwakayama kwakayama commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

After the stable 0.1.1265 release, main no longer publishes prereleases. Set the next base version to 0.1.1266-rc so subsequent main builds can publish release candidates again.

Updates deno.json, the shared version constant, and the generated hydration runtime (version-only change). prebundle-hydration-runtime.ts --check and git diff --check pass.

Follow-through for #4647. Stable 0.1.1265 is published on npm (latest, gitHead 2b5c1d7b5) with GitHub releases v0.1.1265.

Part of the 0.1.1265 release follow-through; no code changes beyond the version line.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T10:42:56.734453Z 74a4022 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 5387dfc3-5807-4cb6-a3f6-958f75c016e9

📥 Commits

Reviewing files that changed from the base of the PR and between 608001d and 74a4022.

⛔ Files ignored due to path filters (1)
  • src/html/hydration-script-builder/hydration-runtime.generated.ts is excluded by !**/*.generated.*
📒 Files selected for processing (2)
  • deno.json
  • src/utils/version-constant.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The project version changes from 0.1.1265 to 0.1.1266-rc in the Deno configuration and the exported VERSION constant.

Changes

Version Update

Layer / File(s) Summary
Update version values
deno.json, src/utils/version-constant.ts
The configured project version and exported VERSION constant change to 0.1.1266-rc.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 74a40

The prerelease version is synchronized across the project and generated runtime. Older versioned requests can still use normal resource lookup, so no material merge risk remains.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 74a40

The inspected client and server paths use matching new version values and keep differently versioned cache entries separate. The release-publication process was not independently verified, so the remaining architecture risk is low rather than minimal.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The inspected security-relevant effect is a change of release-cache identity for versioned module requests, not an expansion of request authority.

Trust Boundaries and Controls

  • observed — Request URL version parameters alone do not qualify a response for the release cache: the server checks them against its active release ID and static VERSION.

Resilience and Maintainability Implications

  • inferred — Version-gated cache admission and per-request Cache-Control reconstruction contain the inspected cache risks during mixed-version operation; live rollout behavior was not exercised.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: opening the 0.1.1266-rc prerelease line.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📦 Client bundle boundary

Entrypoint Modules Source size Server leaks
src/index.client.ts 289 2325 KiB ✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

@gitar-bot

gitar-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

Copy link
Copy Markdown
Contributor Author

Code review: 98/100 — trivial, correct mechanical version bump

This is a routine chore PR that opens the next prerelease line, following the exact same pattern as prior release commits (e.g. #4617 → #4647).

Strengths:

  • Diff is minimal and fully mechanical: deno.json version, src/utils/version-constant.ts, and the generated hydration runtime bundle each change only 0.1.1265 → 0.1.1266-rc. I diffed the large generated-file line programmatically and confirmed the only delta anywhere in that ~79KB string is the version literal — no incidental drift in the bundled runtime code.
  • Matches the established release cadence in git history (chore: open the 0.1.1265-rc prerelease line → release: veryfront 0.1.1265 → this PR), so it's consistent with team convention.
  • PR description documents the verification already run (prebundle-hydration-runtime.ts --check, git diff --check), which is the right narrow check for a version-only change touching a generated file.
  • No public API, behavior, or schema changes — nothing here needs new tests per the repo's own guardrails for a version-constant bump.

Minor notes (non-blocking):

  • mergeable_state currently shows blocked — likely just waiting on required review/checks (CodeRabbit and the automated review bot were still pending at review time), not a defect in the change itself. Worth confirming CI goes green before merge.
  • Since this touches the generated hydration runtime file, it'd be worth double-checking CI regenerates and diffs it with the pinned Deno version (per AGENTS.md) rather than trusting the local --check run alone, to avoid a mismatched-Deno-version false pass.

No functional, security, or test-coverage concerns — this is exactly the shape of diff a version-bump chore should produce.


Generated by Claude Code

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

Copy link
Copy Markdown

@kwakayama

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 74a4022201

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kwakayama
kwakayama added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 9b8e463 Sep 28, 2026
82 checks passed
@kwakayama
kwakayama deleted the chore/open-0.1.1266-rc branch September 28, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant