Revert "ci: cache ~/.conan2 in build workflow" - #85
Merged
Conversation
This reverts commit 7fa563f.
lia (lia-viam)
requested review from
Joseph Borodach (JosephBorodach) and
Sean Pollock (seanavery)
August 11, 2026 15:47
Joseph Borodach (JosephBorodach)
approved these changes
Aug 11, 2026
Contributor
|
Sorry I overlooked this. As we discussed offline, once we have that good example if you can point me to it that would be great because we have 3 other camera modules that are caching conan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #84
lost this in my github notifications, but just recording for posterity that caching conan with github actions is basically always an error, for a couple reasons. the simplest one is that this is the exact purpose of the viam artifactory server, so it's an antipattern to be caching on top of a dedicated, purpose-built cache.
the more complex reason is that github actions caching is not fit to purpose for the level of granularity used by conan to cache binary artifacts, and attempts to distinguish github cache artifacts, eg by runner name or platform, will still lead to collisions and races which show up in basically any nontrivial CI matrix.
looking ahead it would be good if we had a canonical "good example" to point people at for how this should be done, which is that CI jobs should use a lockfile to pin dependency versions, and periodically upload dependencies to the viam conan server if they're slowing down CI