Skip to content

perf: remove virtual dispatch from lock_free_queue #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viknash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: remove virtual dispatch from lock_free_queue #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/lockfreequeue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,17 +242,17 @@ namespace task_scheduler {
{
}

virtual bool push_back(T newData) { return queue.push_back(newData); }
bool push_back(T newData) { return queue.push_back(newData); }

//virtual bool push_front(T newData) { return queue.push_front(newData); }
//bool push_front(T newData) { return queue.push_front(newData); }

virtual bool pop_front(T &val) { return queue.pop_front(val); }
bool pop_front(T &val) { return queue.pop_front(val); }

virtual bool pop_back(T &val) { return queue.pop_front(val); }
bool pop_back(T &val) { return queue.pop_front(val); }

Comment on lines +249 to 252
virtual bool empty() const { return queue.empty(); }
bool empty() const { return queue.empty(); }

virtual ~lock_free_queue() {}
~lock_free_queue() = default;

TPolicy queue;
};
Expand Down
9 changes: 0 additions & 9 deletions include/taskgraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,8 @@ namespace task_scheduler

class task_queue_type : public base_task_queue_type
{
typedef base_task_queue_type super;
public:
task_queue_type(task_memory_allocator_type *allocator);
bool push_back(typename base_task< TMemInterface >::task_type * _new_task);
virtual ~task_queue_type() {}
};

/// <summary>
Expand Down Expand Up @@ -291,12 +288,6 @@ namespace task_scheduler
{
}

template < class TMemInterface >
bool base_task_graph< TMemInterface >::task_queue_type::push_back(typename base_task< TMemInterface >::task_type * _new_task)
{
return super::push_back(_new_task);
}

template < class TMemInterface >
base_task_graph< TMemInterface >::base_task_graph(thread_pool &_pool)
: transient(&task_memory_allocator)
Expand Down