Implement isotropic peak broadening to isotropic pseudo-Voigt profile - #75
Open
clemisch wants to merge 3 commits into
Open
Implement isotropic peak broadening to isotropic pseudo-Voigt profile#75clemisch wants to merge 3 commits into
clemisch wants to merge 3 commits into
Conversation
existed already in anisotropic Pseudo-Voigt profile type. because it's isotropic, add it to default isotropic Pseudo-Voigt. mainly because this is already exposed to Python.
Collaborator
Author
|
Ah, there is a difference to the anisotropic profile: it uses The isotropic PV profile only has shared U,V,W for FWHM and the mixing parameters Eta*. So here, the ...this means it's sensible in practice to activate Eta refinement if P is active. Maybe, ultimately, it's better to expose the more powerful anisotropic PV to pyobjcryst? |
Owner
|
Yes, I think it'd be better to expose the anisotropic PV to pyobjcryst - it can still be used without activating the anisotropic terms. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It already exists in the anisotropic pseudo-Voigt profile in objcryst.
I added it to the isotropic profile because
This broadening model is very limited and the resulting
Pvalue converted to apparent crystallite size should be taken very qualitatively.It might still be useful to have this model to get a good fit, if you're sure observed peak broadening is coming from small crystallites, as the 2θ dependence is very different to existing per-phase Caglioti params U,V,W (which otherwise might be used to account for such effects empirically).
All of this to say: I understand if this addition is deemed not sensible, but for me is has been useful in practice, so here it is.