Fix beta release tags pointing at the wrong commit - #6337
Open
VPS-thodax wants to merge 1 commit into
Open
Conversation
Beta releases on next tag the wrong commit: the GitHub release ends up on the newest main commit instead of the commit that was actually released. v10.0.0-beta.0 is tagged on 0e9bb5f, a main commit. The package tags created by `changeset publish` are correct, which is why only the aggregated vX.Y.Z tag is affected. dotansimha/changesets-action calls the create-release API without passing target_commitish, so GitHub creates the tag on the repository's default branch. Creating the tag ourselves before the action runs fixes this, because GitHub ignores target_commitish when the tag already exists. A second step asserts the result so a broken guard turns into a red job instead of another wrong tag. release.yml is not affected today because main is the default branch, but it gets the same steps: it is the template the vN.x.x branches are cut from, and it should not break silently if the default branch ever changes. Same change as on v8.x.x, where it is confirmed working: v8.32.0 is tagged on cf9fc0c, the release commit on v8.x.x. DEX-2597 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EgLEUzTiJX7Jn3WQJBWhok
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
VPS-Obi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6319 for main
Problem
Beta releases on
nexttag the wrong commit: the tag lands on the newestmaincommit instead of the commit that was released.v10.0.0-beta.0points at0e9bb5fc4("Remove leftover .cspellignore (#6158)"), amaincommit.Cause
dotansimha/changesets-actioncalls the create-release API withouttarget_commitish, so GitHub creates the tag on the repository's default branch.Fix
The release workflows create the
vX.Y.Ztag themselves before the action runs. GitHub ignorestarget_commitishwhen the tag already exists, so the release attaches to the correct commit. A second step then asserts the tag ended up on the released commit and fails the job otherwise.release-beta.ymlis the one that is actually broken here, since it runs onnext.release.ymlgets the same steps even thoughmainis the default branch and therefore unaffected today: it is the template thevN.x.xbranches are cut from, and it should not start tagging wrongly if the default branch ever changes.Verification
v8.x.x. The first release after #6319 merged,v8.32.0, is tagged oncf9fc0cf2— the release commit onv8.x.x, no longer amaincommit.Further information
🤖 Generated with Claude Code
https://claude.ai/code/session_01EgLEUzTiJX7Jn3WQJBWhok
Generated by Claude Code