ci: stabilize readiness retry test - #242
Open
StevenWang-CY wants to merge 1 commit into
Open
Conversation
StevenWang-CY
requested review from
bbrowning,
franciscojavierarceo,
jiahuei,
leseb,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
September 4, 2026 15:40
Signed-off-by: Chuyue Wang <stevenwang0805@outlook.com>
StevenWang-CY
force-pushed
the
fix-python-readiness-test-race
branch
from
September 5, 2026 15:19
3ee31b4 to
6455cae
Compare
Contributor
Author
|
@franciscojavierarceo could you review this? All 12 checks pass after rebasing onto main. This one-file test fix removes the cleanup race while retaining a real HTTP success check; production code is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLErrorfailures followed by a real/v1/modelssuccess through the shared server fixtureOn unmodified
mainat661d8db, the Python 3.13 job completed the readiness request and then failed in test cleanup when its wake-up connection raced the listener closing:ConnectionRefusedErrorwith 113 tests already passing. Python 3.10-3.12 passed in the same matrix. A 200-run local stress control on the untouched test did not reproduce the scheduling-dependent failure.Test Plan
cargo fmt --all -- --checkcargo check --workspace --all-targets --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-features(passed; 5 PostgreSQL tests ignored locally withoutTEST_POSTGRES_URL)Local repository-wide pre-commit hooks passed except that the platform-hanging
check-added-large-filesall-files invocation was skipped; that hook passed directly against the only changed file.Rebased the unchanged patch onto current
mainatc04ac196. All 12 hosted checks pass on head6455cae, including Python 3.10-3.13, Rust, PostgreSQL, both CLI harnesses, pre-commit, and DCO.