[WIP] Fix Spirit Guides visual spell effects. - #3537
Closed
Daribon wants to merge 1 commit into
Closed
Conversation
Stoabrogga
pushed a commit
to Stoabrogga/vmangos
that referenced
this pull request
Aug 22, 2026
Closes vmangos#1208 Closes vmangos#3537 (cherry picked from commit 853e99b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR makes the holy nova visual effect and the casting animation of the spirit guides in battlegrounds work.
This would have been a very simple fix, however for whatever reason when 22011 does trigger 22012, it does so without making the casting animation of 22012 go off (however the spell effect from 22012 does go off)
In order to make 22012 have an animation, it has to be manually cast, which requires you to have a target.
This causes an issue where for each time a player is resurrected, the NPC turns to the location where player was resurrected.
To test this, die once, get resurrected and then die again and watch as NPC has now turned to your previous resurrected location.
The "light beam" spell effect from 22012 lingers on after resurrection for a small bit for all races (as intended), except Night Elves. Not sure if this is a client limitation, but I have no proof that it did linger for Night Elves.
A shitty fix for Night Elves is to just have spell 24171 // Resurrection Impact Visual, be cast as well on the player as it has the light beam effect. However spell 24171 is not seen in any classic sniffs for battlegrounds.
Proof
From issue original issue:
vmangos: https://youtu.be/uM3OPjgLldI
classic: https://youtu.be/I4opumbGyic
From early 2006, that does show the casting animation go off for 22012:
https://youtu.be/1uJMVJxLt1c?si=coWfgAIUURu14gjZ&t=391
Another video from classic:
https://youtu.be/tFl1ifNfrjw?si=R0sXr06FhRRHcqMI&t=297
Issues
How2Test
Todo / Checklist