Replace RUBY_EXPORT with RUBY_FUNC_EXPORTED since it's the recommended way - #97
Open
maxprokopiev wants to merge 1 commit into
Open
Replace RUBY_EXPORT with RUBY_FUNC_EXPORTED since it's the recommended way#97maxprokopiev wants to merge 1 commit into
maxprokopiev wants to merge 1 commit into
Conversation
RUBY_EXPORT used by ruby internally to figure out if library is static or dynamic. The change in ruby/ruby#9828 broke rinku because it couldn't find `ruby_abi_version()` anymore. RUBY_FUNC_EXPORTED is recommended in that case (see https://github.com/ruby/ruby/blob/b2392c6be418703e8941226ac80b359188bf3c5d/lib/bundler/templates/newgem/ext/newgem/extconf-c.rb.tt#L6)
|
Thanks. Required to build on Ruby 3.4. |
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 17, 2025
* Bundler 4.0.2 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * rubocop: rubocop/rubocop#14644 * web-push: for pushpad/web-push#19 * Many precompiled extensions have Ruby < 3.5.dev version constrant that isn't present on the gem itself. Disable all platforms except Ruby to sidestep precompiled gems, forcing compilation. Affects ffi, nokogiri, sqlite3-ruby.
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 17, 2025
* Bundler 4.0.2 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * rubocop: rubocop/rubocop#14644 * web-push: for pushpad/web-push#19 * Many platform-specific gems aren't compiled for Ruby 4 yet. Selective workarounds to force ruby platform for those: ffi, nokogiri, sqlite3-ruby.
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 18, 2025
* Bundler 4.0.2 * Gem upgrades for Ruby 4 compat * rubocop 1.82.0 for rubocop/rubocop#14644 * web-push 3.1.0 for pushpad/web-push#19 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * Many platform-specific gems aren't compiled for Ruby 4 yet, which triggers a Bundler bug wherein it selects a chooses an imcompatible platform-specific gem rather than falling back to the ruby platform and compiling. Fix: ruby/rubygems#9211
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Dec 27, 2025
* Bundler 4.0.3 * Awaiting platform-specific gem: ffi, nokogiri, sqlite3, thruster * Gem upgrades for Ruby 4 compat * rubocop 1.82.0 for rubocop/rubocop#14644 * web-push 3.1.0 for pushpad/web-push#19 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * rubocop: rubocop/rubocop#14644 * web-push: for pushpad/web-push#19 * Many platform-specific gems aren't compiled for Ruby 4 yet, which triggers a Bundler bug wherein it selects a chooses an imcompatible platform-specific gem rather than falling back to the ruby platform and compiling. Fix: ruby/rubygems#9211
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Jan 2, 2026
* Bundler 4.0.3 * Awaiting platform-specific gem: ffi, nokogiri, sqlite3, thruster * Gem upgrades for Ruby 4 compat * rubocop 1.82.0 for rubocop/rubocop#14644 * web-push 3.1.0 for pushpad/web-push#19 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * rubocop: rubocop/rubocop#14644 * web-push: for pushpad/web-push#19 * Many platform-specific gems aren't compiled for Ruby 4 yet, which triggers a Bundler bug wherein it selects a chooses an imcompatible platform-specific gem rather than falling back to the ruby platform and compiling. Fix: ruby/rubygems#9211
jeremy
added a commit
to basecamp/fizzy
that referenced
this pull request
Feb 4, 2026
* Bundler 4.0.3 * Awaiting platform-specific gem: ffi, nokogiri, sqlite3, thruster * Gem upgrades for Ruby 4 compat * rubocop 1.82.0 for rubocop/rubocop#14644 * web-push 3.1.0 for pushpad/web-push#19 * Git sources for fixes and pending releases * rinku: vmg/rinku#97 * rubocop: rubocop/rubocop#14644 * web-push: for pushpad/web-push#19 * Many platform-specific gems aren't compiled for Ruby 4 yet, which triggers a Bundler bug wherein it selects a chooses an imcompatible platform-specific gem rather than falling back to the ruby platform and compiling. Fix: ruby/rubygems#9211
|
Anyway this can get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUBY_EXPORT used by ruby internally to figure out if library is static or dynamic. The change in ruby/ruby#9828 broke rinku because it couldn't find
ruby_abi_version()anymore.RUBY_FUNC_EXPORTED is recommended in that case
(see https://github.com/ruby/ruby/blob/b2392c6be418703e8941226ac80b359188bf3c5d/lib/bundler/templates/newgem/ext/newgem/extconf-c.rb.tt#L6)