Add Proxy.PreserveHost option - #4
Merged
Merged
Conversation
- Add Proxy.PreserveHost (*bool, default true) in internal/waf/proxy and internal/app/config: forward the original client Host to the backend and advertise it via X-Forwarded-Host so backends build correct absolute URLs; set false to rewrite Host to the backend address (previous default behavior) - Add TestPreserveHost covering both preserve and rewrite modes - Document PreserveHost in cfg/local.toml.dist - Document required Captcha.Secret and the memory-storage multi-instance warning in README - Drop baked-in -config/-json flags from deployments/Dockerfile so the config path and log format are supplied at deploy time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Proxy.PreserveHostoption plus docs/deploy polish for the next patch release (v0.0.4).Proxy.PreserveHost(*bool, defaulttrue) ininternal/waf/proxyandinternal/app/config: forwards the original clientHostto the backend and advertises it viaX-Forwarded-Host, so backends build correct absolute URLs. Setfalseto rewriteHostto the backend address (previous default behavior).PreserveHostincfg/local.toml.dist.Captcha.Secretand the memory-storage multi-instance warning inREADME.-config/-jsonflags fromdeployments/Dockerfileso the config path and log format are supplied at deploy time.Hostto the backend address; now (defaultPreserveHost = true) backends receive the original clientHost+X-Forwarded-Host. Deployments relying on the old behavior must setProxy.PreserveHost = false.["/opt/wafsrv/wafsrv"]). The config path (-config/WAFSRV_CONFIG) and-jsonmust be supplied by the orchestrator (Nomad). Without them the container won't findconfig.tomland won't start.Test plan
go build ./...,go vet— cleango test ./internal/...— green; newTestPreserveHostcovers bothpreserveandrewritemodesmake fmt— no changes; lint clean on touched packages (internal/waf/proxy,internal/app)