rtl: keep buffered KMU launches busy - #387
Open
ForeverHYX wants to merge 1 commit into
Open
Conversation
The KMU clears running after the final CTA enters a registered fanout. Downstream busy can take another cycle to propagate, so device busy can briefly fall and make the host report completion while the launch remains buffered. Expose pending from VX_kmu_arb and include it in the busy aggregation at every hierarchy level. Cover the request before and after buffering, and add a Verilator regression that holds a fanout output backpressured across cycles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VX_kmu_arb;level;
into the unit-test catalog.
Fixes #386
Root cause
VX_kmuclearsrunningwhen the final CTA is accepted by the next fanout.When that fanout has
OUT_BUF=3, the CTA may still be held in a registeredoutput before a destination core accepts it. Downstream busy is also registered
through the hierarchy, so producer busy can fall before consumer busy becomes
visible. The resulting false-idle cycle lets a host treat an in-flight launch
as complete.
The fix reports
pendingwhile either side ofVX_kmu_arbis valid and ORsthat state into the existing Vortex/cluster/socket busy aggregation. The core
graphics launch merge uses the same coverage. This changes only completion
visibility; it does not alter request arbitration, data, ready/valid
backpressure, or execution scheduling.
Regression test
The new
hw/unittest/kmu_arbtest instantiates a 1-to-2 arbiter withOUT_BUF=3, transfers one launch into its registered output, then blocks theselected destination for three cycles. It checks that:
pending;request;
The test is registered as
unittest:hw-kmu-arbfor both XLEN configurations.Validation
All commands used an out-of-tree build configured with
--tooldir=$HOME/tools.Sensitivity check with output occupancy intentionally removed:
Restored implementation, XLEN=32 catalog case:
Restored implementation, XLEN=64 catalog case:
Existing adjacent unit tests:
Two-core RTL system checks:
Hardware synthesis smoke:
git diff --check upstream/master: pass.