Skip to content

Fix vote-count sidebar chart floating over the member list below 992px #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffreyBLewis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix vote-count sidebar chart floating over the member list below 992px #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion static/js/voteCharts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,20 @@ function drawWidgets(error, data, geodata, usaboundaries)
}
});

$("#vote_chart_float").delay(500).stick_in_parent();
// Only stick the vote-count chart to the viewport when its column sits
// beside the vote list (Bootstrap's md breakpoint, >=992px). Below that
// the columns stack, so a "stuck" full-width chart would end up pinned
// on top of the vote list underneath it as the page scrolls.
function updateVoteChartSticky() {
var $float = $("#vote_chart_float");
if ($(window).width() >= 992) {
if (!$float.data("sticky_kit")) { $float.stick_in_parent(); }
} else if ($float.data("sticky_kit")) {
$float.trigger("sticky_kit:detach");
}
}
$(window).on("resize", updateVoteChartSticky);
setTimeout(updateVoteChartSticky, 500);
}


Expand Down