Phase 2 (4/5): touch support for the committee page's ideology chart tooltip - #460
Open
JeffreyBLewis wants to merge 1 commit into
Open
Phase 2 (4/5): touch support for the committee page's ideology chart tooltip#460JeffreyBLewis wants to merge 1 commit into
JeffreyBLewis wants to merge 1 commit into
Conversation
…te 4 of 5) Same pattern as party.js's ideology chart tooltip (#459): binds an individual mouseover/mouseout/mousemove handler per data point, so it gets the same bindTouchTap (per point) + bindTouchDismiss (once for the whole set) split rather than one document-wide dismiss listener per point. Verified with headless Chromium on /committees/H_Agriculture: - Desktop (mouse): hover still shows correct content and hides on mouseout - Touch (iPhone 13 emulation): tapping a point shows the tooltip with correct content; tapping elsewhere dismisses it; no page or console errors - Full existing 41-check suite (unrelated files, sanity check only) still passes Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KJMYfgTNsxrmjHZpZKAHT
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #459 so this diff only shows the new commit, `c86a9fd`.
Same pattern as `party.js`'s ideology chart tooltip: binds an individual mouseover/mouseout/mousemove handler per data point, so it gets the same `bindTouchTap` (per point) + `bindTouchDismiss` (once for the whole set) split.
Test plan
Verified with headless Chromium on /committees/H_Agriculture:
🤖 Generated with Claude Code
https://claude.ai/code/session_013KJMYfgTNsxrmjHZpZKAHT