fix(jsonl): map LifecycleError to invalid_request, not internal_error

[Yurii214]

summary

the jsonl/http dispatcher classifies a LifecycleError as internal_error (a server-fault code) instead of invalid_request (a caller-error code). lifecycle.LifecycleError is a RuntimeError, and the dispatcher's clean-caller-error catch only covers (ValueError, ProposalError, ArtifactNotFoundError) — so LifecycleError falls through to the bare except Exception and is logged + returned as internal_error.

concretely, kb.set_goal_status with a bad status:

• lifecycle.set_goal_status validates the status before the goal lookup and raises LifecycleError("unknown goal status …").
• the dispatcher maps that to {"code": "internal_error"}, which clients treat as retryable/alertable — for pure bad input.

the same method is self-inconsistent: an unknown goal id raises ArtifactNotFoundError, which is in the tuple → correctly invalid_request. so a typo'd id is a clean caller error but a typo'd status is a "server fault".

why it's the same class as ProposalError

ProposalError is proposals.py's domain error (also a RuntimeError) and is already mapped to invalid_request. LifecycleError is lifecycle.py's exact sibling and was simply missing from the tuple. all four LifecycleError raise sites — unknown/no-op goal status, self-supersede, self-contradict — are caller conditions, never internal faults, so mapping the whole class is correct.

the other two surfaces already agree: mcp kb_set_goal_status wraps except (LifecycleError, ArtifactNotFoundError): raise ValueError(...), and the cli lists LifecycleError in _cli_errors. tests/test_goals.py states the contract directly — "a host sees ValueError, never an internal exception". jsonl/http were the outlier.

fix

add life.LifecycleError to the dispatcher's invalid_request tuple (life is already imported). one-token change plus a why-comment; no behaviour change for any path that was already correct.

test

test_jsonl_set_goal_status_bad_status_is_invalid_request sends kb.set_goal_status with status="bogus" and asserts error.code == "invalid_request". it fails on the current code (internal_error) and passes with the fix. (status is validated before the goal lookup, so no goal need exist.)

validation

ruff check src tests, mypy src (123 files, no issues), and full pytest tests/ --ignore=tests/embeddings (2991 passed) all green.