fix(delete): include goals in referenced_by and cascade_plan - #731
Open
kurosawareiji7007-hub wants to merge 3 commits into
Open
fix(delete): include goals in referenced_by and cascade_plan#731kurosawareiji7007-hub wants to merge 3 commits into
kurosawareiji7007-hub wants to merge 3 commits into
Conversation
Goals cite claims/entities but the delete gate never walked list_goals, so deleting a cited claim left dangling refs that crashed set_goal_status. Block delete when a goal cites the target, plan goal unlinks for cascade, and apply them via goal.cascade_unlink. Fixes vouchdev#727
github-actions
Bot
added
docs
test_only_lifecycle_mutates_a_stored_goal forbids proposals calling update_goal. Move cascade claim/entity unlinks into lifecycle.cascade_unlink_goal_refs so the single-writer + audit invariant holds. Fixes vouchdev#727
hit entity->goal cascade_plan, ArtifactNotFoundError and no-op unlink paths in lifecycle.cascade_unlink_goal_refs so diff-coverage stays 100%.
Contributor
Author
|
Maintainer note: this is a correctness bugfix. If it looks right, a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
referenced_by/cascade_planwalked pages, claims, and relations but never goals, even thoughGoal.claims/Goal.entitiesare validated refs.set_goal_statuscrashed via_validate_goal_refs.goal.cascade_unlink).Fixes #727
Test plan
uv run pytest tests/test_delete.py tests/test_cascade_delete.py -q