proposal: Optional Material Override Specification for VRM1 - #516
Open
miramocha wants to merge 1 commit into
Open
proposal: Optional Material Override Specification for VRM1#516miramocha wants to merge 1 commit into
miramocha wants to merge 1 commit into
Conversation
Optional engine material on materials[]. Same override JSON shape; open engine strings. English only. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing an optional multi-engine material/shader override specs that will work similar to how VRMC_springBone_extended_collider currently works. It will replace/extend mtoon/khr material when shader is applicable and fallback to mtoon otherwise.
Current working implementation/proof of concept:
https://github.com/miramocha/Extended-VRM-Specs/blob/main/examples/mtoonxt-liltoon-override-warudo.md
In the example implementation page, there is also MToonXT specs but please ignore it for the time being when reviewing this PR as it is not in scope.
Note that on the page/repo the extension name prefix is VRMXT_ to prevent collision with current official source, and we are replacing it with VRMC_ in this proposal.
I'll be happy to discuss, walkthrough, and take any suggestion into consideration, thank you.