Validate versioned Obsidian E2E targets - #46
Merged
Conversation
vrtmrz
marked this pull request as ready for review
August 11, 2026 03:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit version qualification to the real-Obsidian E2E harness, so supported runs use reviewed assets while exploratory versions remain clearly unverified.
Summary
E2E_OBSIDIAN_ALLOW_UNVERIFIED_VERSION=true, label them as unverified probes, and reject that option from the validated suiteRationale
The previous installer derived AppImage names from a single pattern, reused one shared extraction directory, and did not prove that the running renderer matched the requested Obsidian version. That could silently exercise a stale binary, and the derived x86_64 filename did not match the official unsuffixed asset name. Obsidian 1.13.6 also exposed renderer-order and mobile Modal DOM assumptions in the existing harness.
The reviewed catalogue and runtime version check keep release evidence reproducible. The explicit unverified path preserves a convenient early regression probe without treating its result as support evidence.
User and developer impact
Managed Linux E2E now targets Obsidian 1.13.6 by default.
E2E_OBSIDIAN_VERSIONselects another exact reviewed target. A version outside the catalogue requires the explicit unverified option and cannot passtest:e2e:obsidian:validated.Executable discovery and session start-up remain offline operations; AppImages are downloaded only by the explicit installer command.
Verification
NODE_OPTIONS=--max-old-space-size=3072 npm run verify:workspaceNODE_OPTIONS=--max-old-space-size=3072 npm run verify:packed-consumer