bug: fix visibility of outdated banner and refactor - #1176
Merged
Conversation
|
Deployment previews on netlify for branch
|
…erenced by date This patch introduces a PoC workaround to not use the route but the active_from date to determine if the policy being rendered is the current or upcoming one. Bug: T434193
tarrow
force-pushed
the
T434193-2-pero-tarrow
branch
from
August 25, 2026 13:36
4f1f5ac to
0975783
Compare
- remove policyMetadata property of component - replace with specific property for the policyActiveFrom date - specifically catch and continue only on Axios 404s and rethrow other errors
tarrow
marked this pull request as ready for review
August 25, 2026 14:30
outdooracorn
changed the title
outdooracorn
changed the title
A request will use the first route it matches. Therefore, the '/hosting-policy/:activeFrom' route must come after all other hosting policy routes otherwise the `activeFrom` parameter can be `upcoming` and `pilot`.
* Prevents `this.renderPage()` from being called multiple times on a single page load. * Helps to simplify the logic and make this file easier to parse.
outdooracorn
changed the title
outdooracorn
approved these changes
Aug 26, 2026
outdooracorn
left a comment
outdooracorn
left a comment
Member
There was a problem hiding this comment.
Works for me locally. Let's get this shipped. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only display the outdated banner on policies accessed via specific URL when appropriate.
Fixes a misunderstanding that the route contains enough information and instead uses the API response as the single source of truth.
This patch introduces extra requests when loading policy pages but is fine for now.
Fixes route ordering in
route/index.js. A request will use the first route it matches. Therefore, the '/hosting-policy/:activeFrom' route must come after all other hosting policy routes otherwise theactiveFromparameter can beupcomingandpilot.Simplify the policy renderers loading by removing computed properties and adding a watch on route changes. This also fixes the flashing of banners and temporarily displaying an incorrect banner on page load.
Removes the hard-coded path to component path mapping and dynamically imports the policy contents.
Bug: T434193
Bug: T434862