Skip to content

Update accname/name/comp_host_language_label.html with hidden label tests - #44183

Open
rahimabdi wants to merge 6 commits into
masterfrom
rahim/update-accname-host-label-tests
Open

Update accname/name/comp_host_language_label.html with hidden label tests#44183
rahimabdi wants to merge 6 commits into
masterfrom
rahim/update-accname-host-label-tests

Conversation

@rahimabdi

Copy link
Copy Markdown
Contributor

@MelSumner

Copy link
Copy Markdown
Contributor

I'm a little confused about this one. I thought that there was existing, explicit language that a hidden label does not provide a valid name for an input, but these tests seem to suggest that browsers support the opposite. What am I missing here? I could use a brief chat on this one, I think.

@cookiecrook

cookiecrook commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

Yes, and I am concerned that this diff greatly increases the Chrome/Gecko failure percentages of a file included in an Interop 2024 Focus Area. Perhaps we can start by adding any new tests that fail to a new .tentative file (so they don't affect the Interop score), and then consider the subtests one by one. In particular the promise rejections are likely b/c the test is calling for computedlabel on unrendered elements, which may be exposing a legitimate implementation detail that should not be tested in the meantime.

@cookiecrook cookiecrook left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in convo tab.

@cookiecrook

Copy link
Copy Markdown
Contributor

Bulk edit of stale PRs... If you're the original submitter or assignee, will you dig back through the history and determine what the next steps are? Thanks.

@rahimabdi

Copy link
Copy Markdown
Contributor Author

@MelSumner @cookiecrook I believe this PR can be closed in lieu of this @adampage WPT PR achieving the same: #44965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants