Stop caching local build artifacts in Actions workflows - #233
Merged
Conversation
The release cache restored the whole dist-newstyle directory keyed only on the dependency freeze file, so a stale local package build (including its inplace package registration) could be reused even after the source or the package version changed. Cache only the external Cabal store; local packages build fresh every run.
Same stale-cache risk as the release build: keying the cache only on the freeze file lets a stale local package build, including its inplace package registration, survive a source or version change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist-newstyledirectory keyed only on the dependency freeze file. Since dependencies rarely change, the same cache entry was reused for weeks, and a stale local package build (including its registered inplace package) could survive a source or version change. This actually happened: a tagged release build shipped a binary that still reported version 0.0.5.0 and the pre-change transformation behaviour, despite the tag's.cabalfile saying 0.0.6.0.build-and-test.yamlandfuture-proofing.yamlcache their cabal builds the same way and carry the same risk, even though it hasn't been observed there yet.jbeam-editand its internal libraries) now build fresh every run, so there's nothing stale to reuse.