feat(plugin-meetings): report new WASM runtime metrics - #5159
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2cd24132c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Replace the local link with web-capabilities 1.13.0. This keeps telemetry testing and releases reproducible.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| .then((result) => { | ||
| const {status, capability, reason, measurements} = result; | ||
| const { | ||
| divRatio = null, |
There was a problem hiding this comment.
Do we intentionally want them to be null if these values are missing in measurements object because as per the logic they will be undefined anyways
There was a problem hiding this comment.
Yes @Kesari3008, good comment, this was intentional. undefined fields will be omitted during JSON.stringify, while null explicitly indicates that the probe did not produce measurements and keeps the telemetry fields consistent across results.
Kesari3008
left a comment
There was a problem hiding this comment.
Minor comment to understand the intent there
Thank you for your contribution! |
COMPLETES
Related to SPARK-844160
This pull request addresses
js_sdk_wasm_runtime_performancetelemetry to support the new WASM-only probe.by making the following changes
@webex/web-capabilities@1.13.0.status,capability,reason,divRatio,sqrtRatio,addNsPerOp, and median timings.ratio,wasmMs, andjsMsfields.Change Type
The following scenarios were tested
Automated testing
yarn workspace @webex/plugin-meetings test:unitPassedyarn workspace @webex/plugin-meetings buildPassedManual verification
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that