fix: keep vendor/ on the host instead of a named volume - #15
Merged
Conversation
The container is only a test runner. A vendor:/app/vendor named volume hid dependencies from the developer's host tree and forced Composer I/O through the Docker Desktop VM layer. vendor/ is now part of the plain .:/app bind mount; only the composer-cache named volume remains.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The \ ooling\ service mounted \�endor:/app/vendor\ as a named volume. That hid dependencies from the developer's host tree (no \�endor/\ visible in the working copy) and forced all Composer I/O through the Docker Desktop VM layer, pegging the CPU during installs.
Change
The container is only a test runner: \�endor/\ is now part of the plain .:/app\ bind mount, so the host copy is the single source of truth. Only the \composer-cache\ named volume remains.
Matches the updated webware-tools alignment preset (webinertia/webware-tools@feb2e49) and the verified fix in webware-log PR #61.