build: update changesets tooling - #2396
Conversation
Move the changelog generator to the @changesets/get-github-info 1.0 API (getInfo/getInfoFromPullRequest became getCommitInfo/getPullRequestInfo, the links bag became per-entity markdownLink fields, and both lookups can now return undefined), and take dependabot's changesets/action v2.1.0 pin. The package is now ESM-only and ships an exports map with no main, which the eslint import resolver cannot follow, so import/no-unresolved is off for that one file.
🦋 Changeset detectedLatest commit: f5754e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 4 4
Lines 1242 1242
Branches 380 380
=======================================
Hits 1169 1169
Misses 65 65
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. WalkthroughThe changelog generator now uses Merge Risk: 🔵 Low · up to This updates release tooling to a dependency that does not support the project's stated Node 20 baseline, so release commands may fail on supported Node 20 environments. The PR is otherwise mergeable with explicit maintainer awareness and a follow-up decision on the Node support baseline. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 2e176136-b188-4c73-918f-ecd96fb4becd
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.changeset/changelog-generator.mjs.changeset/update-changesets-tooling.md.github/workflows/release.ymleslint.config.mjspackage.json
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.
| "@babel/preset-env": "^7.29.7", | ||
| "@changesets/cli": "^3.0.1", | ||
| "@changesets/get-github-info": "^0.8.0", | ||
| "@changesets/get-github-info": "^1.0.0", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
printf '%s\n' '--- package manifest ---'
sed -n '50,72p' package.json
printf '%s\n' '--- lockfile entries ---'
rg -n -A12 -B3 '"?`@changesets/get-github-info`|node_modules/@changesets/get-github-info|engines' package-lock.json yarn.lock pnpm-lock.yaml 2>/dev/null || true
printf '%s\n' '--- Node 20 baseline declarations ---'
rg -n -i 'node.?20|engines|setup-node|runtime' package.json .nvmrc .node-version .github 2>/dev/null | head -120Repository: webpack/webpack-dev-middleware
Length of output: 50387
🏁 Script executed:
python3 - <<'PY'
import json
from pathlib import Path
for name in ("package.json", "package-lock.json"):
p = Path(name)
if not p.exists():
continue
data = json.loads(p.read_text())
print(f"--- {name} ---")
if name == "package.json":
print("engines:", data.get("engines"))
print("dependency:", data.get("devDependencies", {}).get("`@changesets/get-github-info`"))
print("scripts:", {k:v for k,v in data.get("scripts", {}).items() if "release" in k or "change" in k})
else:
node = data.get("packages", {}).get("node_modules/@changesets/get-github-info")
root = data.get("packages", {}).get("", {})
print("root engines:", root.get("engines"))
print("root devDependency:", root.get("devDependencies", {}).get("`@changesets/get-github-info`"))
print("package entry:", node)
PY
printf '%s\n' '--- version-control and CI Node declarations ---'
for f in .nvmrc .node-version; do [ -f "$f" ] && { echo "[$f]"; cat "$f"; }; done
rg -n -i -g '!package-lock.json' -g '!node_modules' 'node-version|NODE_VERSION|node: *20|node 20|node\.js *20|engines' package.json .github README.md 2>/dev/null | head -160Repository: webpack/webpack-dev-middleware
Length of output: 1870
🏁 Script executed:
printf '%s\n' '--- release workflow and install policy ---'
sed -n '1,120p' .github/workflows/release.yml
printf '%s\n' '--- package manager and npm engine policy ---'
for f in .npmrc .yarnrc .yarnrc.yml pnpm-workspace.yaml; do [ -f "$f" ] && { echo "[$f]"; cat "$f"; }; done
rg -n -i 'npm (ci|install)|yarn install|pnpm install|engine-strict|changeset|release' .github package.json . 2>/dev/null | head -180
printf '%s\n' '--- direct package references ---'
rg -n -F '`@changesets/get-github-info`' --glob '!package-lock.json' --glob '!node_modules' .Repository: webpack/webpack-dev-middleware
Length of output: 12943
🏁 Script executed:
printf '%s\n' '--- changelog generator imports ---'
sed -n '1,100p' .changeset/changelog-generator.mjs
printf '%s\n' '--- package engine and Node 20 workflow context ---'
sed -n '96,114p' package.json
sed -n '55,88p' .github/workflows/nodejs.ymlRepository: webpack/webpack-dev-middleware
Length of output: 4720
Keep @changesets/get-github-info compatible with Node 20.
The repository supports Node >=20.9.0 and tests Node 20.x. The locked @changesets/get-github-info@1.0.0 declares only ^22.11 || ^24 || >=26. Use a Node 20-compatible version or raise the repository and workflow baseline together.
Source: MCP tools
v2 renamed every input this workflow passes (version -> version-script, publish -> publish-script, commit -> commit-message, title -> pr-title), so a bare SHA bump silently drops them. Without publish-script the action only opens a version pull request and never publishes. Also stop the changelog generator printing a literal 'null' when a changeset names an author but GitHub reports no commit or pull request, which 1.0 can now do because both lookups may return undefined.
1 participant
Summary
Takes
@changesets/get-github-info1.0, which renamed its whole API, and rewrites.changeset/changelog-generator.mjsagainst it:getInfo/getInfoFromPullRequestbecamegetCommitInfo/getPullRequestInfo, thelinksbag became per-entitymarkdownLinkfields, and both lookups can now returnundefined. Also takes dependabot'schangesets/actionv2.1.0 pin from #2384 (inputs unchanged), which supersedes that PR.Rehearsed
changeset versionwith the GitHub calls stubbed to the 1.0 response shape and confirmed byte-identical changelog lines across all three paths — commit lookup,pr:lookup, and theauthor:/commit:overrides. Against the real package it now fails only on missing credentials rather than aTypeError, which is the expected local outcome.Babel 8 is not included: it declares
engines: ^22.18.0 || >=24.11.0, so it does not run on Node 20, which this package supports (>= 20.9.0) and CI tests. Adopting it means dropping Node 20, which is a maintainer decision rather than a dependency bump — dependabot's #2337/#2338/#2343 are blocked on the same thing.What kind of change does this PR introduce?
build
Did you add tests for your changes?
No — release tooling with no test surface; verified by rehearsing
changeset versionend to end and bynpm ciplus the existing suite passing.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
AI was used. Claude Code rewrote the changelog generator against the 1.0 API, rehearsed the release path with stubbed GitHub responses, diagnosed the babel 8 Node-baseline conflict, and drafted this description; every claim above was verified by running the commands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KUpsHWHZG2FxHzJxRUvVv3
Generated by Claude Code
Summary by CodeRabbit
Bug Fixes
Release Process
webpack-dev-middlewarereflecting these changelog-generation improvements.