Skip to content

Update biochar realization with changes for stylized scenarios - #81

Closed
k4rst3ns wants to merge 142 commits into
weindl:f_biochar_newSys_BU2from
k4rst3ns:f_cdrEU
Closed

Update biochar realization with changes for stylized scenarios#81
k4rst3ns wants to merge 142 commits into
weindl:f_biochar_newSys_BU2from
k4rst3ns:f_cdrEU

Conversation

@k4rst3ns

Copy link
Copy Markdown

🐦 Description of this PR 🐦

  • get updates from develop and updates from biochar stylized scenario work into biochar feature branch

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

pvjeetze and others added 30 commits April 29, 2025 14:29
Co-authored-by: pvjeetze <vjeetze@pik-potsdam.de>
…ion further

    Co-authored-by: pvjeetze <vjeetze@pik-potsdam.de>
…ons-input-data

merge patrick branch with LUH3 and FAO fix
k4rst3ns and others added 27 commits January 5, 2026 12:44
Update setting for residue demand for 2nd generation (including startign script for recalculation)
Co-authored-by: georg-schroeter <Georg.Schroeter@pik-potsdam.de>
i63_biochar_prod(t,i,biopyr_all63) = f63_biochar_prod(t,i,biopyr_all63,"R2M41-SSP2-NPi");
$endif

** Harmonize until predefined time step if not applied in coupled or emulator set-up

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this harmonization out of the loop but now I am unsure, if this was correct.
Here we should discuss again, when merging this!!!

@weindl weindl closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants