fix(tui): Esc stops the flow, and the card and ident hold ground [spec 10] - #139
Merged
Conversation
…c 10]
Three user reports from one guided-install session, spec 10 + spec 03-03:
- The murmur wordmark scrolled away the moment the guide's tool narration
flooded the log. In the wide composition the ident is now pinned between
the scene band and the log (identPinned) whenever the log region can spare
its rows; narrow and cramped layouts keep the classic in-log ident.
- A running setup flow could not be stopped without quitting the radio. Esc
now rides the wire as `interrupt`: runSetup registers a flow-scoped stop
latch on the new Host.onInterrupt seam for its whole duration (opening
probes included), reads decline through, the SDK session is cut, pending
ask cards drop on both sides (`askDrop`), and the write_voice_config tool
aborts instead of validating/persisting on a declined secret read.
- The per-turn reply prompt opened a spotlight card that carried no question
("murmur is asking" over "your reply"). It is an info line now; the modal
stays reserved for the onboarding decisions (consent, seeds, secret paste).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Team-workspace Codex seat hit its owner-set spend cap and gpt-5.5 is no longer the strongest reviewer; the ship loop now reviews on gpt-5.6-sol. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements specs/spec10/10-tui.md (§2.3, §3.2-B, §3.3, §3.4) and specs/spec03/03-03-guide-harness.md (§7).
Three user reports from one real guided-install session:
The wordmark scrolled away the moment the guide's tool narration flooded the log. In the wide composition the station ident is now pinned between the scene band and the log (
identPinnedintui/src/logo.ts) whenever the log region can spare its rows (≥ 2× the ident's six); narrow and cramped layouts keep the classic in-log ident.A running setup flow could not be stopped without quitting. Esc (with no menu/pane open) now rides the wire as
interrupt;runSetupregisters a flow-scoped stop latch on the new optionalHost.onInterruptseam for its whole duration — opening probes included. Reads decline through as'', the guide's SDK session is cut via its interrupt promise, the closing re-probe is skipped, pending ask cards drop on both sides (askDrop, deliberately outside the replay backlog), andwrite_voice_configaborts instead of validating/persisting on a declined secret read. With no flow registered (first-run seeds, the broadcast) the interrupt is noise and the cards stand.The per-turn reply prompt opened a contentless spotlight card ("murmur is asking" over "your reply"). It is an info line now; the modal card stays reserved for the onboarding decisions (consent checklist, first-run seeds, the secret paste).
Rider: the murmur-ship closing review pins
gpt-5.6-sol(the Team seat's spend cap killedgpt-5.5runs; user picked the 5.6 flagship).Verification
pnpm testgreen (all suites, incl. new regressions: stop-latch reads, Esc at offer/probes/mid-conversation, askDrop routing + no-flow noise, aborted secret write, wire round-trip,identPinned);tsc+ oxlint clean.pyte, 180×48, stub brain): after 25 typed lines flood the log, the wordmark stands pinned above the scrolling tail, and Esc reaches the engine (interrupt received with no flow to stop; ignoredin dev.log) without crashing.gpt-5.6-sol, xhigh): 3 findings, 3 applied (abort seam for the secret tool, Esc armed before the probes, comment date-stamps stripped); code-review skill (high): 3 findings, 3 applied (same two + a one-line closure for Esc at the offer). First codex attempt on the Team seat died on its spend cap — mechanical skip, rerun on the Pro login.AI coding brief
gpt-5.5in favor ofgpt-5.6-sol.🤖 Generated with Claude Code