You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A previous PR I did, #83, added a fix for obtaining data with arrayNames in MLControl's getLocaleFieldName method. However, loading data with arrayNames was not implemented. This PR aims to fix this issue by doing a basic implementation within the getLocaleValue and getLocaleSaveValue methods.
It has not been thoroughly tested; the main tests were for an implementation with the Blocks plugin, which uses arrayNames.
A previous PR I did, #83, added a fix for obtaining data with arrayNames in MLControl's getLocaleFieldName method. However, loading data with arrayNames was not implemented. This PR aims to fix this issue by doing a basic implementation within the getLocaleValue and getLocaleSaveValue methods. It has not been thoroughly tested; the main tests were for an implementation with the Blocks plugin, which uses arrayNames.
Any input is welcome.
Does this work when $this->valueFrom is used as well?
A previous PR I did, #83, added a fix for obtaining data with arrayNames in MLControl's getLocaleFieldName method. However, loading data with arrayNames was not implemented. This PR aims to fix this issue by doing a basic implementation within the getLocaleValue and getLocaleSaveValue methods. It has not been thoroughly tested; the main tests were for an implementation with the Blocks plugin, which uses arrayNames.
Any input is welcome.
Does this work when $this->valueFrom is used as well?
As long as arrayName should be applied to $this->valueFrom, then yes, as this uses the $key variable.
Yes, thank you and thanks @mjauvin for the emrge. I haven't worked with winter in a bit, but getting these things done helps. Appreciate all the work you've done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR I did, #83, added a fix for obtaining data with arrayNames in
MLControl'sgetLocaleFieldNamemethod. However, loading data with arrayNames was not implemented. This PR aims to fix this issue by doing a basic implementation within thegetLocaleValueandgetLocaleSaveValuemethods.It has not been thoroughly tested; the main tests were for an implementation with the Blocks plugin, which uses arrayNames.
Any input is welcome.