Trim the newcomer card's meta line and drop the ordering promise - #1664
Merged
Conversation
wintermeyer
force-pushed
the
feed-newcomer-meta-trim
branch
from
August 24, 2026 17:33
6b33016 to
72d727f
Compare
Die Beitrittszeile ("seit 3 Tagen dabei · ") war interessant und kostete ein
Drittel jeder Zeile für eine Auskunft, die die Überschrift der Karte schon gibt
— fünf Zeilen tief hat sie nichts eingebracht. Übrig bleibt der Jobtitel, und
wo keiner eingetragen ist, fällt die Zeile ganz weg statt leer dazustehen.
Damit verliert VutuvWeb.UserHTML.joined_line/1 seinen einzigen Aufrufer und
fällt weg, und die Abfrage lädt inserted_at nicht mehr mit.
Die Einleitung sagte "Die zuletzt dazugekommenen Mitglieder" und versprach
damit eine Reihenfolge, die das Nachziehen sichtbar widerlegt: die Karte zieht
zufällig aus den neuesten. Jetzt "Ein paar der neuesten Mitglieder".
Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das
problematisch ist.
wintermeyer
force-pushed
the
feed-newcomer-meta-trim
branch
from
August 24, 2026 17:41
72d727f to
286846e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom In the
/feedrail's "Neu dabei" card, each row's meta line led with "seit 3 Tagen dabei · " before the job title. Interesting, but it ate a third of every row for a fact the card's own heading already makes — five rows deep that bought nothing. The intro also read "Die zuletzt dazugekommenen Mitglieder", promising an order that the ↻ visibly contradicts: the card draws randomly from the newest.Changed (
VutuvWeb.PostLive.Feed, the#newcomerscard) The meta line is the job title alone, and a member who has not filled one in gets no line at all rather than an empty one. The intro is now "Ein paar der neuesten Mitglieder. Ihnen zu folgen ist eine herzliche Begrüßung."Removed with it
VutuvWeb.UserHTML.joined_line/1loses its only caller and goes, along with its four msgids;Social.newest_members_with_avatar/1no longer selectsinserted_at.Hot deploy, v7.345.2.
mix precommitgreen.An AI agent wrote this text in my name. I know that is problematic.