Feed: drop the unread dot on the All tab - #1670
Merged
Merged
Conversation
Der Feed setzte den Punkt bisher auch auf "Alle", weil dort ja ebenfalls liegt, was auf dem anderen Reiter gelandet ist. Technisch stimmte das und las sich trotzdem falsch: drei markierte Reiter sehen nach drei Orten mit eigenen Neuigkeiten aus, obwohl es nur einer ist. `unseen_tabs/1` gibt deshalb nur noch die benannten Quellen zurück; das Löschen bleibt, wie es war, denn wer auf "Alle" sitzt, bekommt jede Ankunft ohnehin sofort in die Pille gelegt. Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist. Claude-Session: https://claude.ai/code/session_01MkxtjXUsUHPMPEAfEDMrwC
wintermeyer
force-pushed
the
worktree-red-dot
branch
from
August 24, 2026 20:43
a525a4e to
70b1234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
/feed, an arrival on the tab you are not reading dotted three tabs: the source it landed on and "Alle". That is true — "Alle" shows the same post — but three marked tabs read as three places with news of their own when there is only one.unseen_tabs/1inVutuvWeb.PostLive.Feednow returns only the named sources. Clearing is unchanged: sitting on "Alle" streams every arrival straight into the "new posts" pill, so nothing can be unseen there anyway.Tests in
feed_source_tabs_test.exsflipped to assert "Alle" never dots; the sharedpost_filter_tabs/1component is untouched.mix precommitgreen.An AI agent wrote this text in my name. I know that is problematic.
https://claude.ai/code/session_01MkxtjXUsUHPMPEAfEDMrwC