Block Playwright traffic to Google Analytics - #32
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ziodave
force-pushed
the
fix/block-playwright-ga
branch
from
August 6, 2026 08:36
9538ac7 to
bf91f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.google-analytics.comand*.analytics.google.commainVerification
Service-worker tradeoff
Blocking service workers prevents analytics requests from escaping page interception, but intentionally reduces fidelity for PWA caching, offline behavior, and service-worker background activity.
Baseline note
The repository-wide suite still has 13 unrelated pre-existing collection errors because the installed generated
wordlift-clientpackage lacksfetch_apiandfetch_js_render_mode. Repository-wide Ruff reports 28 existing violations outside this diff, and the format check identifies 39 existing files that would be reformatted.