Adding xcms readexperiment file for XCMS4 based experiment#403
Adding xcms readexperiment file for XCMS4 based experiment#403CTR-LABERCA wants to merge 9 commits into
Conversation
|
This PR looks like a real replacement of the old tools not an evolution of the old. What about adding v4 as a new folder and don't touch the old ones. There is no tool linkage we can keep and no upgrade path for a user. So we will end up with new tools in the tool panel. The we can also keep them separate on GitHub. What do you think? |
|
@CTR-LABERCA why did you remove all other files? from what I can see, this just replaces reading the experiment. |
|
@hechth @bgruening @yguitton and I discussed this point at length. We didn't really see read_msExperiment as a replacement. Rather, it's the first tool that creates an MsExperiment object, which is new in xcms v4. The subsequent tools, such as abims_fill_chromPeaks, xcms_plot_chromatogram, and others, will only be updated to support xcms v4. In the rush, we only kept the new files dedicated to xcms 4 and opened a new pull request. We had a hard time deciding how to organize the transition, which led to this confusion. I'll fix everything. Sorry about that. |
|
@lecorguille @melpetera the last error is a url time out.. any clues? |
|
The questions that we need to answer are:
If one or both questions can be answered with yes, we start a new folder and put in new XML files and do not touch the old ones. |
|
The main change introduced by the migration to XCMS 4 is the replacement of the MSnExp data container with the MsExperiment data container during the initial data import step. The workflow structure remains identical, while the selected tool version would determine whether the underlying data container is MSnExp (XCMS 3) or MsExperiment (XCMS 4). All subsequent preprocessing steps—peak detection, peak grouping, retention time alignment, and peak filling—remain conceptually unchanged. The idea, we have in mind in this context, is to allow users to select between installed version with the built-in version selector. |
FOR CONTRIBUTOR: