Skip to content

chore(lint): enable no-console rule - #34

Open
tupe12334 wants to merge 3 commits into
mainfrom
lint/enable-no-console
Open

chore(lint): enable no-console rule#34
tupe12334 wants to merge 3 commits into
mainfrom
lint/enable-no-console

Conversation

@tupe12334

Copy link
Copy Markdown
Member

What

Enables the no-console ESLint rule in eslint.config.mjs:

"no-console": ["error", { allow: ["warn", "error"] }]

Errors on console.log / console.debug / console.info / etc., while keeping intentional console.warn and console.error available.

Why

Stops stray debugging console.log statements from shipping to the public landing site, and forces real diagnostics through warn/error so intent is explicit. See #33 for the full rationale.

Safety / verification

  • 0 lint violations — no source changes needed beyond the config.
  • pnpm run lint
  • pnpm run build
  • Single rule, error level; no other rules touched.

Closes #33


This pull request was opened by the "Add lint rule → issue + PR (owned repos + my orgs) → Slack" routine of moadim, on behalf of @tupe12334.

Disallow console.log/debug/etc. (allow warn/error) so debugging
leftovers do not ship to production. 0 current violations.

Closes #33

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Preview deployment

🚀 https://2823a589.worktree-io-landing.pages.dev

@tupe12334

Copy link
Copy Markdown
Member Author

Resolved merge conflict against main via manual-merge-both-kept (kept this PR's noConsoleOverride config block alongside a sibling PR's typeImportsOverride block, and merged both into the eslint export default array). Skipped the local lint check since node_modules was not installed and a full install was out of scope for this fix.

Posted by the moadim routine "Resolve conflicts on code-quality PRs (non-guiddeco)".

@github-actions

Copy link
Copy Markdown

Preview deployment

🚀 https://31c437d9.worktree-io-landing.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable no-console lint rule

1 participant