refactor: make key sealing and blob storage async - #503
Closed
Dzejkop wants to merge 1 commit into
Closed
Conversation
Dzejkop
force-pushed
the
codex/async-key-sealer
branch
from
September 2, 2026 16:55
6d68277 to
1099cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceKeystore/KeystoretoKeySealer, renameopen_sealedtounseal, and describe the non-secret binding input ascontextKeySealerandAtomicBlobStoreoperations async through both the plain Rust and UniFFI adapter layersStorageKeys::init,CredentialStore::init, and the correspondingAuthenticatorstorage lifecycle asyncwalletkit-dbdocumentation for the new APIThe
contextcontract is behavioral: unsealing under a different context must fail. Adapters may satisfy it with AEAD AAD, context-specific key selection, or an equivalent mechanism.Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo clippy --workspace --all-targets -- -D warningscargo clippy --workspace --all-targets --no-default-features -- -D warningscargo test -p walletkit-db(11 passed)cargo test -p walletkit-core --lib(138 passed)cargo test -p walletkit-core --test credential_storage_integration(1 passed)nix develop .#wasm --command cargo check -p walletkit --features embed-zkeys --target wasm32-unknown-unknown