chore: align Rust toolchains on 1.97.1 - #509
Draft
Dzejkop wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin WalletKit's development, CI, crate release, and Swift release compilers to Rust 1.97.1 for the shared Rust rollout. Refresh only the Nix Rust overlay so the host, WASM, and Android shells can resolve this release. Fix the two test-only Clippy findings exposed by the new compiler.
The test matrix now explicitly selects
RUSTUP_TOOLCHAINand covers 1.97.1, stable, nightly, and the declared 1.91 MSRV. The workspace MSRV remains 1.91, verified with an all-targets/all-features workspace check on 1.91.0. Nightly documentation builds remain intentional. Cargo dependencies and Cargo.lock are unchanged.Validation
cargo fmt -- --check.-D warningsfor all features, default features, and no default features.cargo test -p walletkit-db -p walletkit-sqlite --locked --offline— 21 tests passed.cargo check --workspace --all-targets --all-features --locked --offline.cargo deny --offline check bans licenses sources(cargo-deny 0.20.2).git diff --check.Builds used pinned Nargo 1.0.0-beta.11. Network access was needed for pinned build-script assets. Full RPC/Foundry integration tests, cross-target builds, browser tests, foreign binding tests, and nightly docs are left to CI. Cargo reports an existing future-incompatibility warning in proc-macro-error2 2.0.1.
Rollout dependency
Keep this PR in draft until the coordinated infrastructure rollout sets the organization
RUST_TOOLCHAIN_CHANNELvariable to1.97.1and participating repositories are ready. Version alignment remains enforced and will fail while the organization variable differs. No live variable or infrastructure changes are made here.This is the future Rust upgrade, separate from walletkit #508 and the Flamingo 1.94.1 downgrade in worldcoin/flamingo#88. It does not change that integration branch or PR.