feat(frontend): give integer widths a legality rule and their own diagnostic - #17
Merged
Merged
Conversation
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
BornPsych
changed the base branch from
provekit-v2
to
ys/goldilocks-stage-5a
September 16, 2026 09:25
BornPsych
added this pull request to stack #18
September 16, 2026 09:25
BornPsych
force-pushed
the
ys/goldilocks-stage-5b
branch
from
September 16, 2026 09:40
f337bea to
0158fcb
Compare
BornPsych
force-pushed
the
ys/goldilocks-stage-5b
branch
from
September 22, 2026 13:39
1053453 to
05f4b9a
Compare
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 5b of the Goldilocks port: the standard library now elaborates under a field that is not bn254, taking the 62 errors
nargo check --field goldilocksused to report down to zero. A field attribute can name every field but the one given,#[field(not(bn254))], and gating reaches types, traits and aliases too, so an impl leaves along with the type its module dropped. Behind that gate the bn254-only modules go (embedded curve ops, poseidon2,field/bn254), hashing and wrapping arithmetic each grew a second half for narrow fields, and 93 per-width numeric impls collapse into 26 generic ones overu<N>andi<N>. On bn254 nothing moves: all 509execution_successprograms keep identical ACIR opcode counts.